Changeset 1869

Timestamp:

09/11/08 14:21:59 (2 months ago)

Author:

duncan

svm:headrev:

cc3e1ea1-1e01-0410-8d68-8b121e83a9d5:11151

Message:

[ 2230783 ] audio.detach plugin broken
Fix applied. The menu select event was being ignored when a new track started to play

Location:

freevo/src/audio

Files:

• player.py (modified) (4 diffs)
• plugins/detach.py (modified) (2 diffs)

freevo/src/audio/player.py

@@ -35 +35 @@
 import rc
 import plugin
-import event
+from event import *
 
 from util.benchmark import benchmark
@@ -103 +103 @@
             if self.visible:
                 rc.app(None)
-            self.item.eventhandler(event.PLAY_END)
+            self.item.eventhandler(PLAY_END)
         else:
             if self.visible:
@@ -147 +147 @@
     def show(self):
         if not self.visible:
-            self.visible = 1
+            self.visible = True
             self.refresh()
             rc.app(self.player)
@@ -155 +155 @@
     def hide(self):
         if self.visible:
-            self.visible = 0
+            self.visible = False
             skin.clear()
             rc.app(None)

freevo/src/audio/plugins/detach.py

@@ -42 +42 @@
 benchmarking = config.DEBUG_BENCHMARKING
 benchmarkcall = config.DEBUG_BENCHMARKCALL
-benchmarking = 0
-benchmarkcall = False
 
 class PluginInterface(plugin.MainMenuPlugin):
@@ -115 +113 @@
                 PluginInterface.detached = False
                 p.eventhandler(Event('STOP'))
-            elif event == MENU_PLAY_ITEM:
+            elif event == PLAY_START and gui.visible:
                 rc.post_event(plugin.event('ATTACH'))